chore: price feeder imports umee/v2.0.0 #766
Conversation
…app/params: import lookup disabled by -mod=readonly
|
All tests passing - but let's hold up on merging this until v2 PR is in main or perhaps further |
toteki
changed the title
price-feeder/go.mod
Outdated
| module github.com/umee-network/umee/price-feeder | ||
| module github.com/umee-network/umee/v2/price-feeder |
There was a problem hiding this comment.
This change - is it correct?
edit: to test this, try importing price feeder into a fresh go.mod based project. If it errors "why does 0.2 have a v2 url?" then I will revert this line
There was a problem hiding this comment.
The v2 is for the umee part, the price-feeder is in its own version like 0.20
Maybe it wouldn't be better for the price-feeder to have its own repository?
@toteki @adamewozniak
There was a problem hiding this comment.
Long term, separate repo could simplify things.
As for the price-feeder/go.mod import path, this PR might work without (since only the umee go.mod, not the whole umee repository, has changed import paths).
Codecov Report
@@ Coverage Diff @@
## main #766 +/- ##
==========================================
- Coverage 48.03% 47.60% -0.43%
==========================================
Files 64 64
Lines 9329 9413 +84
==========================================
Hits 4481 4481
- Misses 4581 4665 +84
Partials 267 267
|
|
Finished a local test of importing price feeder at this commit on an empty / "hello world" type of project, and confirmed no errors appear with the non-v2 import path. Merging now. |
* all replaces EXCEPT in price feeder - not complete * go mod replace price feeder 0.2 * fix make proto-gen output folder to allow major versions * revert some price feeder path changes * cannot find module providing package github.com/umee-network/umee/v2/app/params: import lookup disabled by -mod=readonly * chore: pf importing umee/v2 * Update price-feeder/go.mod * go mod tidy --compat=1.17 * try undo price feeder v2 import path Co-authored-by: toteki <63419657+toteki@users.noreply.github.com> (cherry picked from commit 11c0f76) # Conflicts: # price-feeder/go.sum
* all replaces EXCEPT in price feeder - not complete * go mod replace price feeder 0.2 * fix make proto-gen output folder to allow major versions * revert some price feeder path changes * cannot find module providing package github.com/umee-network/umee/v2/app/params: import lookup disabled by -mod=readonly * chore: pf importing umee/v2 * Update price-feeder/go.mod * go mod tidy --compat=1.17 * try undo price feeder v2 import path Co-authored-by: toteki <63419657+toteki@users.noreply.github.com> (cherry picked from commit 11c0f76)
* all replaces EXCEPT in price feeder - not complete * go mod replace price feeder 0.2 * fix make proto-gen output folder to allow major versions * revert some price feeder path changes * cannot find module providing package github.com/umee-network/umee/v2/app/params: import lookup disabled by -mod=readonly * chore: pf importing umee/v2 * Update price-feeder/go.mod * go mod tidy --compat=1.17 * try undo price feeder v2 import path Co-authored-by: toteki <63419657+toteki@users.noreply.github.com> (cherry picked from commit 11c0f76) Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
Description
umee/v2Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change