Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: increase x/oracle unit test coverage (backport #786) #795

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 11, 2022

This is an automatic backport of pull request #786 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* add empty request test

* add unit test for grpc_query_test

* add missing tests to grpc

* add str tests for oracle vote

* add #786 to changelog

* add changelog to 788

* add unit tests to oracle-params

* add changelog to 789

* update tests, comments and rename

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>

* modified tests to be more readable

* update unit tests to use testSuite

Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
(cherry picked from commit f0389b7)
@mergify mergify bot requested review from a team as code owners April 11, 2022 16:07
@codecov-commenter
Copy link

Codecov Report

Merging #795 (da8f8d6) into release/v2.x.x (f0882c9) will increase coverage by 2.25%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release/v2.x.x     #795      +/-   ##
==================================================
+ Coverage           47.51%   49.77%   +2.25%     
==================================================
  Files                  64       64              
  Lines                9426     9426              
==================================================
+ Hits                 4479     4692     +213     
+ Misses               4680     4486     -194     
+ Partials              267      248      -19     
Impacted Files Coverage Δ
x/oracle/types/test_utils.go 42.39% <ø> (ø)
x/oracle/keeper/grpc_query.go 100.00% <0.00%> (+42.10%) ⬆️
x/oracle/types/params.go 100.00% <0.00%> (+50.84%) ⬆️
x/oracle/types/vote.go 100.00% <0.00%> (+53.22%) ⬆️
x/oracle/types/keys.go 100.00% <0.00%> (+100.00%) ⬆️
x/oracle/types/denom.go 100.00% <0.00%> (+100.00%) ⬆️

@adamewozniak adamewozniak merged commit 88dbc12 into release/v2.x.x Apr 11, 2022
@adamewozniak adamewozniak deleted the mergify/bp/release/v2.x.x/pr-786 branch April 11, 2022 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants