chore: format once with gofumpt #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toteki
commented
Apr 11, 2022
| return sdk.NewDecWithPrec(050, 3).Add(sdk.NewDecWithPrec(int64(r.Intn(950)), 3)) | ||
| return sdk.NewDecWithPrec(50, 3).Add(sdk.NewDecWithPrec(int64(r.Intn(950)), 3)) |
There was a problem hiding this comment.
Note: formatter actually wanted to change this to 0o050 (octal), which is not what the code was intended to do, but is what it was actually doing.
Manually removed leading zeroes in the three lines changed for this file.
| @@ -46,7 +46,7 @@ func (s *IntegrationTestSuite) SetupTest() { | |||
| } | |||
|
|
|||
| // CreateTestTx is a helper function to create a tx given multiple inputs. | |||
| func (suite *IntegrationTestSuite) CreateTestTx(privs []cryptotypes.PrivKey, accNums []uint64, accSeqs []uint64, chainID string) (xauthsigning.Tx, error) { | |||
| func (suite *IntegrationTestSuite) CreateTestTx(privs []cryptotypes.PrivKey, accNums, accSeqs []uint64, chainID string) (xauthsigning.Tx, error) { | |||
There was a problem hiding this comment.
imo defining parameter types like accNums []uint64, accSeqs []uint64, becomes a lot more readable when it comes to longer function definitions, so we probably shouldn't enforce it in CI - wdyt?
There was a problem hiding this comment.
I personally favor the shortened ones, except when they're separated by newlines in which case each one gets a type.
But CI could be overkill either way
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
* gofumpt -l -w . * gofumpt -l -w -extra . * remove unintentional octal (cherry picked from commit 2802898)
mergify bot
pushed a commit
that referenced
this pull request
Apr 12, 2022
* gofumpt -l -w . * gofumpt -l -w -extra . * remove unintentional octal (cherry picked from commit 2802898)
adamewozniak
pushed a commit
that referenced
this pull request
Apr 12, 2022
adamewozniak
pushed a commit
that referenced
this pull request
Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Formatting pass using gofumpt, a stricter
gofmtIt might be worth using this in CI like a linter.
No functionality changes, so probably doesn't need a changelog.