Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add go tool tip to makefile #803

Merged
merged 3 commits into from
Apr 13, 2022
Merged

chore: add go tool tip to makefile #803

merged 3 commits into from
Apr 13, 2022

Conversation

RafilxTenfen
Copy link
Contributor

@RafilxTenfen RafilxTenfen commented Apr 12, 2022

Description

  • Add go tip to the makefile to generate easily readable coverage
  • run make test-unit-cover
  • open it in the browser with go tool cover -html=coverage.txt
    image

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@RafilxTenfen RafilxTenfen requested a review from a team as a code owner April 12, 2022 19:22
@RafilxTenfen RafilxTenfen self-assigned this Apr 12, 2022
@RafilxTenfen
Copy link
Contributor Author

@toteki Maybe we could add it as a new command in the make and check if exists the coverage.txt file, if not runs test-unit-cover first

What do you think ?

@RafilxTenfen RafilxTenfen marked this pull request as draft April 12, 2022 19:24
@toteki
Copy link
Member

toteki commented Apr 12, 2022

make cover-html perhaps?

And probably have it run test-unit-cover always in case changes have been made.

@RafilxTenfen RafilxTenfen marked this pull request as ready for review April 12, 2022 21:11
@RafilxTenfen RafilxTenfen requested a review from a team as a code owner April 12, 2022 21:11
@toteki toteki merged commit 76102b7 into main Apr 13, 2022
@toteki toteki deleted the rafilx/go-tool-tip branch April 13, 2022 02:41
mergify bot pushed a commit that referenced this pull request Apr 13, 2022
* add go tool tip to makefile

* add cover-html command to makefile

* add changelog of make cover-html

(cherry picked from commit 76102b7)
toteki pushed a commit that referenced this pull request Apr 13, 2022
* add go tool tip to makefile

* add cover-html command to makefile

* add changelog of make cover-html

(cherry picked from commit 76102b7)

Co-authored-by: Rafael Tenfen <rafaeltenfen.rt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants