-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: liquidate command from-address #829
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: This is in the client so it's not state machine breaking. We can merge it into any release. |
adamewozniak
approved these changes
Apr 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just need the test fixed 👍
Codecov Report
@@ Coverage Diff @@
## main #829 +/- ##
=======================================
Coverage 50.93% 50.93%
=======================================
Files 64 64
Lines 9428 9428
=======================================
Hits 4802 4802
Misses 4383 4383
Partials 243 243
|
toteki
changed the title
fix: liquidate command was using borrower address as liquidator
fix: liquidate command from-address
Apr 22, 2022
mergify bot
pushed a commit
that referenced
this pull request
Apr 22, 2022
(cherry picked from commit 183987d)
adamewozniak
pushed a commit
that referenced
this pull request
Apr 22, 2022
This was referenced Apr 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
liquidate command was using borrower address as liquidator
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md