Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add missing market summary CLI query #918

Merged
merged 2 commits into from
May 17, 2022
Merged

feat: add missing market summary CLI query #918

merged 2 commits into from
May 17, 2022

Conversation

toteki
Copy link
Member

@toteki toteki commented May 17, 2022

Description

Register the missing CLI query for MarketSummary.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added appropriate labels to the PR
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #918 (7c92390) into main (d919765) will decrease coverage by 0.17%.
The diff coverage is 0.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #918      +/-   ##
==========================================
- Coverage   51.08%   50.90%   -0.18%     
==========================================
  Files          64       64              
  Lines        9425     9456      +31     
==========================================
- Hits         4815     4814       -1     
- Misses       4365     4397      +32     
  Partials      245      245              
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/oracle/types/query.pb.gw.go 0.00% <ø> (ø)
x/leverage/keeper/grpc_query.go 5.55% <2.77%> (-0.77%) ⬇️

@toteki
Copy link
Member Author

toteki commented May 17, 2022

Confirmed working - if running starport locally, it works at

http://localhost:1317/umee/leverage/v1/market_summary?denom=uumee

Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Please change the title to `feat: add missing market summary CLI query" & add a changelog entry though 😄

@toteki toteki requested a review from a team as a code owner May 17, 2022 20:42
@toteki toteki changed the title fix: add missing market summary CLI query feat: add missing market summary CLI query May 17, 2022
@toteki toteki merged commit b0f2dde into main May 17, 2022
@toteki toteki deleted the adam/query branch May 17, 2022 21:06
mergify bot pushed a commit that referenced this pull request May 17, 2022
* fix: add missing market summary CLI query

* cl++

(cherry picked from commit b0f2dde)
toteki added a commit that referenced this pull request May 17, 2022
* fix: add missing market summary CLI query

* cl++

(cherry picked from commit b0f2dde)

Co-authored-by: toteki <63419657+toteki@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants