Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update upstream gravity module to fix halt bug #932

Merged
merged 2 commits into from
May 20, 2022

Conversation

dreamcodez
Copy link
Contributor

@facundomedica was able to contribute the halting fix upstream albeit still in an unversioned release.

bumps gravity module to 8d660b559b0718c6ff4e20f3b355d94501d8dbb3

ran:

go get github.com/Gravity-Bridge/Gravity-Bridge/module@8d660b559b0718c6ff4e20f3b355d94501d8dbb3

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@dreamcodez dreamcodez marked this pull request as ready for review May 20, 2022 16:59
@dreamcodez dreamcodez requested a review from a team as a code owner May 20, 2022 16:59
Copy link
Collaborator

@adamewozniak adamewozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WAGMI

@codecov-commenter
Copy link

Codecov Report

Merging #932 (ab34d69) into main (d3546fd) will decrease coverage by 0.00%.
The diff coverage is 52.73%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #932      +/-   ##
==========================================
- Coverage   50.90%   50.90%   -0.01%     
==========================================
  Files          64       64              
  Lines        9456     9479      +23     
==========================================
+ Hits         4814     4825      +11     
- Misses       4397     4401       +4     
- Partials      245      253       +8     
Impacted Files Coverage Δ
x/leverage/client/cli/query.go 0.00% <0.00%> (ø)
x/leverage/keeper/genesis.go 2.15% <0.00%> (ø)
x/leverage/keeper/grpc_query.go 5.55% <0.00%> (ø)
x/leverage/keeper/interest.go 78.16% <0.00%> (-4.32%) ⬇️
x/leverage/keeper/reserves.go 78.94% <ø> (+2.99%) ⬆️
x/leverage/types/query.pb.gw.go 0.00% <0.00%> (ø)
x/leverage/keeper/keeper.go 45.88% <51.28%> (-1.66%) ⬇️
x/leverage/keeper/token.go 61.73% <55.55%> (+1.34%) ⬆️
x/leverage/keeper/oracle.go 67.07% <66.66%> (-2.16%) ⬇️
x/leverage/client/tests/suite.go 100.00% <100.00%> (ø)
... and 10 more

@dreamcodez dreamcodez merged commit 7f178e3 into main May 20, 2022
@dreamcodez dreamcodez deleted the matt/bump-gravity-bridge-halt-fixed-upstream branch May 20, 2022 17:55
@toteki
Copy link
Member

toteki commented May 20, 2022

@Mergifyio backport release/v2.x.x

mergify bot pushed a commit that referenced this pull request May 20, 2022
* go get github.com/Gravity-Bridge/Gravity-Bridge/module@8d660b559b0718c6ff4e20f3b355d94501d8dbb3

* bump gravity module on price-feeder as well to 8d660b559b07

(cherry picked from commit 7f178e3)

# Conflicts:
#	price-feeder/go.mod
#	price-feeder/go.sum
@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

backport release/v2.x.x

✅ Backports have been created

toteki pushed a commit that referenced this pull request May 20, 2022
…#933)

* chore: update upstream gravity module to fix halt bug (#932)

* go get github.com/Gravity-Bridge/Gravity-Bridge/module@8d660b559b0718c6ff4e20f3b355d94501d8dbb3

* bump gravity module on price-feeder as well to 8d660b559b07

(cherry picked from commit 7f178e3)

# Conflicts:
#	price-feeder/go.mod
#	price-feeder/go.sum

* fix malformed go.mod for price-feeder

Co-authored-by: Matthew Elder <sseses@gmail.com>
Co-authored-by: Matthew A Elder <matthew@umee.cc>
@adamewozniak
Copy link
Collaborator

@Mergifyio backport release/price-feeder/v0.2.x

mergify bot pushed a commit that referenced this pull request May 20, 2022
* go get github.com/Gravity-Bridge/Gravity-Bridge/module@8d660b559b0718c6ff4e20f3b355d94501d8dbb3

* bump gravity module on price-feeder as well to 8d660b559b07

(cherry picked from commit 7f178e3)

# Conflicts:
#	go.mod
@mergify
Copy link
Contributor

mergify bot commented May 20, 2022

backport release/price-feeder/v0.2.x

✅ Backports have been created

adamewozniak added a commit that referenced this pull request May 20, 2022
…#934)

* chore: update upstream gravity module to fix halt bug (#932)

* go get github.com/Gravity-Bridge/Gravity-Bridge/module@8d660b559b0718c6ff4e20f3b355d94501d8dbb3

* bump gravity module on price-feeder as well to 8d660b559b07

(cherry picked from commit 7f178e3)

# Conflicts:
#	go.mod

* fix merge conflict

* tidy

* tidy++

Co-authored-by: Matthew Elder <sseses@gmail.com>
Co-authored-by: Adam Wozniak <29418299+adamewozniak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants