fix(node-polyfill): node polyfill not work when ident in shorthand notation

[stormslowly]

problem

console.log({process}); 

the origin implementation don't handle the ident in object which not wrapped in Expression.

solution

visit ident directly

Summary by CodeRabbit

• Refactor
  • Refactored the visit_mut_expr method into visit_mut_ident in the Provide implementation for improved identifier processing.
  • Added a new test function test_provide_in_shorthand_notation to test shorthand notation for providing modules.

[coderabbitai]

Walkthrough

The changes involve refactoring the visit_mut_expr method into visit_mut_ident in the Provide implementation, altering how identifiers are processed and require declarations are generated. A new test function test_provide_in_shorthand_notation has been added to test shorthand notation for providing modules.

Changes

File	Summary
crates/mako/src/visitors/provide.rs	Refactored visit_mut_expr into visit_mut_ident in Provide impl, changes in identifier processing, added test function.

Poem

In code's dance, identifiers now prance,
Refactored with a new test's chance.
Modules provided in shorthand's embrace,
CodeRabbit hops, with changes in place. 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

---

Commits

Files that changed from the base of the PR and between 145d70e and d198553.

Files selected for processing (1)

• crates/mako/src/visitors/provide.rs (2 hunks)

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.