Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatenate): ignored module should be treated as external #1149

Merged
merged 4 commits into from
May 11, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented May 10, 2024

内部发现用例,如果 ignore module 参与合并,因为 tree-shaking 后 ast 为空,所以不插入任何代码
那么所有引用自 ignored modules 的变量都会变成 undefined 变量。

解:

ignored module 不参与合并

Summary by CodeRabbit

  • 新功能
    • 为应用程序添加了搜索功能。
    • 优化了模块图的逻辑,以确定模块是内部模块还是根模块。
    • 引入了测试工具和模块处理的修改,确保文件正确连接,同时排除特定模块。
    • 引入了用于验证导入实体和常量值的测试。
    • pkg模块的index.js文件添加了额外的console.log语句。
    • pkg模块的package.json文件中指定了在浏览器环境中忽略index.js

Copy link
Contributor

coderabbitai bot commented May 10, 2024

摘要

Walkthrough

这次的变更涉及到 mako crate 中的几个文件和模块的调整,主要包括修改结构体字段、添加新字段以及更新模块内部逻辑。同时还引入了一些新文件和测试用例,以确保文件正确连接并排除特定模块。

Changes

文件 变更摘要
crates/mako/src/build/mod.rs
crates/mako/src/module.rs
修改了 ModuleInfo 结构体,添加了 is_ignored 字段
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate.rs 更新了 optimize_module_graph 函数的逻辑,影响了模块的分类条件
e2e/fixtures/mako.scope-hoisting.ignored-module/expect.js
e2e/fixtures/mako.scope-hoisting.ignored-module/index.js
e2e/fixtures/mako.scope-hoisting.ignored-module/inner.js
e2e/fixtures/mako.scope-hoisting.ignored-module/mako.config.json
e2e/fixtures/mako.scope-hoisting.ignored-module/node_modules/pkg/index.js
e2e/fixtures/mako.scope-hoisting.ignored-module/node_modules/pkg/package.json
引入了新文件和模块,包括测试用例、配置文件以及模块的调整和说明

诗歌

兔子编码忙碌中,代码变更如歌声,

新字段添一处,旧逻辑更新行;

文件连结需小心,排除模块更精准,

代码世界变迁迅,兔子畅游其中。🐇📝

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 4a0f2ad into master May 11, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/ignored_module_concatenated branch May 11, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants