Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 🔧 adjust puffin for easy profile for both long time compiling and watch mode #1168

Merged
merged 2 commits into from
May 20, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented May 15, 2024

  1. compile.build 数据放在第一帧,方便抓取长时间构建的项目数据
  2. update 的数据在构建后正常显示,方便选择

Summary by CodeRabbit

  • Bug Fixes
    • main.rs中,根据特性进行条件导入,删除未使用的导入,重构异步代码以进行性能分析,更改闭包中的参数传递。
    • utils/mod.rs中,为profile_gui模块的声明添加了条件编译属性#[cfg(feature = "profile")]
    • profile_gui.rs中,重构以使用Compiler结构而不是Notify,调整初始化逻辑,并根据编译器上下文参数进行编译和服务器生成。

Copy link
Contributor

coderabbitai bot commented May 15, 2024

Walkthrough

这次更新主要涉及条件导入、未使用导入的删除、异步代码重构以用于性能分析,以及在闭包中传递不同的参数。

Changes

文件 摘要
crates/mako/src/main.rs 条件导入改变,删除未使用导入,异步代码重构,闭包中参数改变
crates/mako/src/utils/mod.rs utils/mod.rsprofile_gui模块声明中添加了条件编译属性
crates/mako/src/utils/profile_gui.rs 重构使用Compiler结构替代Notify,调整初始化逻辑,基于编译器上下文参数进行编译和服务器生成

Poem

小兔编码忙碌间,条件导入换新颜,异步代码优化心田种,闭包参数如诗篇。 🐇📝

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc merged commit 1a64d2a into master May 20, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the chore/tool_puffin_profile_for_build branch May 20, 2024 09:00
stormslowly added a commit that referenced this pull request May 20, 2024
…and watch mode (#1168)

* chore: 🔧 adjust puffin for easy profile for long time compiling

* refactor: 🎨 move profile logic to profile app
sorrycc added a commit that referenced this pull request May 27, 2024
* feat: ✨ add [d]ynamic [r]equire runtime function

* refactor: 🎨 dynamic import require process with interop

* test: ✅ add test case

* test: ✅ import context module adjust to dynamic import

* release: @umijs/mako@0.4.18-canary.20240517.1

* chore: ⬆️ mako 0.4.18-canary.20240517.1

* chore: ⬆️ update pnpm-lock

* typo

* fix: fix "too many files open" error when watching with-antd example (#1022)

* fix: fix "too many files open" error when watching with-antd example

* fix: include dist dictionary of root's parent dictionary when watching

---------

Co-authored-by: zp365238 <zp365238@antgroup.com>
Co-authored-by: pshu <pishu.spf@antfin.com>

* chore: 🔧 adjust puffin for easy profile for both long time compiling and watch mode (#1168)

* chore: 🔧 adjust puffin for easy profile for long time compiling

* refactor: 🎨 move profile logic to profile app

* fix: decorator visitor should run before preset env (#1176)

* test: ✅ add runtime assert in decorator and target to chrome 40

* fix: 🐛 move decorator before preset_env

* add comment on decorators

* feat: add watch.ignorePaths config (#1179)

* release: @umijs/mako@0.4.18-canary.20240520.1

* chore: ⬆️ v0.4.18-canary.20240520.1

* chore: ⬆️ update pnpm-lock

---------

Co-authored-by: zhangpanweb <37805064+zhangpanweb@users.noreply.github.com>
Co-authored-by: zp365238 <zp365238@antgroup.com>
Co-authored-by: chencheng (云谦) <sorrycc@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants