Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: find available port automatically when port is in use #1266

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Jun 11, 2024

见图。

image

Summary by CodeRabbit

  • 新功能
    • 为开发服务器添加了查找可用端口的功能。
  • 对公开实体的声明进行更改
    • crates/mako/src/dev/mod.rs中,将use std::net::SocketAddr;更改为use std::net::{SocketAddr, TcpListener};
    • crates/mako/src/dev/mod.rsimpl DevServer中添加了fn find_available_port(host: String, port: u16) -> u16 { ... }

Copy link
Contributor

coderabbitai bot commented Jun 11, 2024

摘要变更

crates/mako/src/dev/mod.rs: ## 简短摘要
在 `crates/mako/src/dev/mod.rs` 中的变更涉及添加功能以查找开发服务器的可用端口,处理端口冲突,并更新相关逻辑。

## 导出或公共实体声明的更改
- `crates/mako/src/dev/mod.rs` 中的 `use std::net::SocketAddr;` → `crates/mako/src/dev/mod.rs` 中的 `use std::net::{SocketAddr, TcpListener};`
- 在 `crates/mako/src/dev/mod.rs` 中的 `impl DevServer` 中添加了 `fn find_available_port(host: String, port: u16) -> u16 { ... }`

漫游

整体变更涉及在开发模块中添加了查找可用端口的功能,处理端口冲突,并更新了相关逻辑。

变更

文件路径 变更摘要
crates/mako/src/dev/mod.rs 添加了查找可用端口的功能,处理端口冲突,更新相关逻辑。
crates/mako/src/dev/mod.rs 导出声明中添加了 TcpListener

诗歌

兔子跳跃在代码间,

端口冲突不再烦恼,

TcpListener悄然至,

开发服务器更从容,

代码世界更精彩。 🐰🌟


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc mentioned this pull request Jun 11, 2024
5 tasks
@sorrycc sorrycc merged commit 0f254dd into master Jun 11, 2024
8 checks passed
@sorrycc sorrycc deleted the sorrycc-hhxv branch August 9, 2024 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant