Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hmr static server not response correct content-type #1307

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

whyer11
Copy link
Contributor

@whyer11 whyer11 commented Jun 25, 2024

Fix the garbled text issue caused by the missing "charset=utf-8" in the Content-Type response header of JS files by the HMR static server.

  • replace hyper-staticfile to hyper-staticfile-jsutf8
  • add hmr test case

Summary by CodeRabbit

  • 新功能
    • 更新了mako包的依赖版本,包括hyper-staticfilecoloredhyper等。新增了一个名为hyper-staticfile-jsutf8的依赖项。
    • 引入了React组件Test,在app.tsx文件中渲染两个<h1>元素,一个展示“中文中文”,另一个展示“Hello World!”。
    • 将配置设置从顶层键移到嵌套的devServer对象中,特别是将devtoolstatshash设置移到devServer中的hostport设置中。
  • 修复问题
    • 修复了scripts/test-hmr.mjs中JavaScript文件响应的内容类型检查问题,确保在热更新场景下匹配预期值。

Copy link
Contributor

coderabbitai bot commented Jun 25, 2024

摘要

  • Walkthrough:
    项目变更概览:更新了包括依赖版本、模块引入和配置设置等多方面的修改,主要集中在更新依赖版本和调整模块引入方式上。

  • 变更:

    文件 变更概要
    crates/mako/Cargo.toml 更新了多个依赖版本,新增了 hyper-staticfile-jsutf8 依赖。
    crates/mako/src/dev/mod.rs 更新了关于 hyper_staticfile 的引入,并影响了 DevServer 实现中的初始化。
    examples/normal/app.tsxexamples/normal/index.tsx 引入了新的 React 组件 Test,并在 index.tsx 中引入并使用了该组件。
    examples/normal/mako.config.json 调整了配置设置的结构。
    scripts/test-hmr.mjs 修改了两个文件中的内容,涉及到 JavaScript 文件响应内容类型的测试变更。

诗歌

兔兔编码改革中,魔法般的变迁。

依赖更新闪耀光,模块引入如风轻。

React 组件新登场,配置移至新源兴。

测试变革有序行,兔兔乐园变化情。


Note

Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@whyer11 whyer11 requested a review from sorrycc June 25, 2024 09:26
@sorrycc sorrycc merged commit 272061a into master Jun 25, 2024
8 checks passed
@sorrycc sorrycc deleted the fix/hmr_js_charset branch June 25, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants