-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade hyper-staticfile, which fix the js file charset problem #1363
Conversation
Walkthrough
Changes
Poem
Tip AI model upgrade
|
For more details, you can refer to the pull request made by the author of hyper_staticfile: here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
Cargo.lock
is excluded by!**/*.lock
Files selected for processing (2)
- crates/mako/Cargo.toml (1 hunks)
- crates/mako/src/dev/mod.rs (3 hunks)
Files skipped from review due to trivial changes (1)
- crates/mako/Cargo.toml
Additional comments not posted (3)
crates/mako/src/dev/mod.rs (3)
20-20
: 导入更改已批准导入语句已更新为使用
hyper_staticfile
,符合升级库的目标。
78-79
: 更改已批准,但请验证集成
serve
函数中的Static
实例创建已更改为使用hyper_staticfile::Static::new
。请确保该更改在整个函数中正确集成。
124-124
: 更改已批准,但请验证集成
handle_requests
函数中的Static
参数类型已更改为hyper_staticfile::Static
。请确保该更改在整个函数中正确集成。
The hyper_staticfile has been fixed according to our issue and is now compatible with both application/javascript and text/javascript content types that may be returned by mime_guess.
Summary by CodeRabbit
hyper-staticfile-jsutf8
依赖为hyper-staticfile
,改进了静态文件处理功能。