fix(tree-shaking): detect export var side effects #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Walkthrough此次更改涉及多个文件的更新，主要包括对 Changes
Poem
Tip Announcements
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (6)
Files skipped from review due to trivial changes (4)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
e2e/fixtures/tree-shaking.export_var_decl/src/index.tsx (1)
1-6: 测试覆盖率不完整：缺少对导出变量keep的测试根据脚本输出，
export_var.js文件中导出的变量keep没有对应的测试用例。这表明测试覆盖率不完整，建议为该变量添加测试用例以确保其副作用被正确验证。
- 导出变量
keep缺少测试用例。Analysis chain
测试用例看起来不错，但需要验证测试覆盖率。
这个测试文件导入了
recorder.js中的getStore函数和export_var，并包含一个测试用例来检查export var中的副作用是否被保留。测试用例的实现看起来是正确的，但是由于没有提供export_var文件的上下文，所以无法验证测试用例是否足够全面。请提供
export_var文件的内容，以便验证测试用例是否覆盖了所有可能的场景。例如，可以运行以下脚本来检查export_var文件中是否存在未被测试覆盖的导出变量声明：Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify all exported variable declarations in `export_var` are covered by tests. # Test: Search for exported variable declarations. Expect: Each one has a corresponding test case. rg --type js $'export\s+var' e2e/fixtures/tree-shaking.export_var_decl/src/export_var.js | while read -r line ; do var_name=$(echo "$line" | sed -E 's/export\s+var\s+(\w+).*/\1/') if ! rg -q -F "record($var_name)" e2e/fixtures/tree-shaking.export_var_decl/src/export_var.js; then echo "Exported variable $var_name does not have a corresponding test case." fi doneLength of output: 439
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- crates/mako/src/plugins/tree_shaking/statement_graph/analyze_imports_and_exports.rs (7 hunks)
- crates/mako/src/plugins/tree_shaking/statement_graph/rustfmt.toml (1 hunks)
- e2e/fixtures/tree-shaking.export_var_decl/expect.js (1 hunks)
- e2e/fixtures/tree-shaking.export_var_decl/src/export_var.js (1 hunks)
- e2e/fixtures/tree-shaking.export_var_decl/src/index.tsx (1 hunks)
- e2e/fixtures/tree-shaking.export_var_decl/src/recorder.js (1 hunks)
Files skipped from review due to trivial changes (4)
- crates/mako/src/plugins/tree_shaking/statement_graph/analyze_imports_and_exports.rs
- crates/mako/src/plugins/tree_shaking/statement_graph/rustfmt.toml
- e2e/fixtures/tree-shaking.export_var_decl/expect.js
- e2e/fixtures/tree-shaking.export_var_decl/src/export_var.js
Additional comments not posted (1)
e2e/fixtures/tree-shaking.export_var_decl/src/recorder.js (1)
1-9: 代码看起来不错！这个文件实现了一个全局的
record函数和一个导出的getStore函数。record函数将输入值推入store数组并返回输入值，getStore函数返回store数组。代码正确实现了记录值和提供对记录值的访问的功能。
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1579 +/- ##
==========================================
+ Coverage 62.03% 62.04% +0.01%
==========================================
Files 127 127
Lines 15353 15355 +2
==========================================
+ Hits 9524 9527 +3
+ Misses 5829 5828 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem
mako tree-shaking treats export var as no side effect
solution
correct self execute flag for export var stmt
Summary by CodeRabbit
新特性
record和getStore，实现数值的存储和检索。keep的导出，便于其他模块访问。文档
rustfmt.toml文件，设置最大行宽为120个字符，以提高代码可读性。修复