Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate_package_checker panic when no package.json is supplied #1621

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Sep 30, 2024

Before.

Building with mako for production...
● Mako ▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨▨ (28%) transform_js transform_js                                                                thread 'Mako thread 10' panicked at crates/mako/src/plugins/duplicate_package_checker.rs:102:66:
called `Option::unwrap()` on a `None` value
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Rayon: detected unexpected panic; aborting
[1]    53972 abort      OKAM=  build

How to reproduce?

umi g page index
umi config set mako {}
umi build

Summary by CodeRabbit

  • 新功能

    • 改进了重复包检查插件的功能,增强了对包信息的提取和检查。
  • Bug 修复

    • 优化了对 package_json 的检查,避免了潜在的错误。
  • 重构

    • 代码结构更清晰,提高了对缺失数据的处理能力。

@sorrycc sorrycc merged commit 34619ef into master Sep 30, 2024
1 check passed
Copy link
Contributor

coderabbitai bot commented Sep 30, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

此次更改主要集中在 DuplicatePackageCheckerPlugincheck_duplicates 方法上,优化了从模块图中提取包信息的方式。新实现通过检查 package_json 是否存在来避免潜在的解包错误,整体流程更加清晰且对缺失数据的处理更为稳健。尽管构造 PackageInfo 实例的逻辑未变,但插件的结构和目的仍然是识别和报告重复的包版本。

Changes

文件路径 更改摘要
crates/mako/src/plugins/...checker.rs 优化 check_duplicates 方法,改进 package_json 的提取方式,增强代码的稳健性。

Possibly related PRs

Poem

在兔子洞里跳跃欢,
重复包不再烦。
检查方法更聪明,
代码流畅如春风。
感谢小小的改动,
让我们一起欢庆这时光! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sorrycc sorrycc deleted the sorrycc-iwq8 branch September 30, 2024 08:41
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.97%. Comparing base (0652492) to head (3ec038c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
+ Coverage   61.95%   61.97%   +0.01%     
==========================================
  Files         154      154              
  Lines       15412    15412              
==========================================
+ Hits         9549     9551       +2     
+ Misses       5863     5861       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant