fix: normalize Windows paths in Compiler output path handling #1745

sorrycc · 2025-01-08T06:31:44Z

as pictures below.

Summary by CodeRabbit

新功能
- 改进了路径处理功能，增强了对Windows路径的支持。
Bug 修复
- 优化了路径字符串的生成方法，提高了跨平台兼容性。

coderabbitai · 2025-01-08T06:31:51Z

概述

演练

这个拉取请求修改了 crates/mako/src/stats.rs 文件中的 print_stats 方法。主要变更是引入了 win_path 函数，并在构建路径字符串时使用该函数替代了原有的直接转换方法。这一更改可能与处理 Windows 风格路径有关，同时保持了方法的整体功能不变。

变更

文件	变更摘要
`crates/mako/src/stats.rs`	新增 `win_path` 函数导入修改 `print_stats` 方法中路径字符串构建逻辑

可能相关的 PR

fix: win path problem with context module and require context #1742：在 ContextModulePlugin 结构体的 load 方法中使用 win_path 函数，与本 PR 类似
fix: normalize Windows paths in ModuleId constructors #1744：更新 ModuleId 结构体，通过 win_path 函数处理 id 字段

诗歌

🐰 代码之路，路径转换
Windows 风格，兔子欢畅
win_path 魔法，悄然启航
字符串跳舞，代码飞扬
兔子编程，路径无疆！

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 66535b5 and bcc5973.

📒 Files selected for processing (1)

crates/mako/src/stats.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (13)

GitHub Check: stable - i686-pc-windows-msvc - node@20
GitHub Check: stable - x86_64-pc-windows-msvc - node@20
GitHub Check: stable - aarch64-unknown-linux-musl - node@20
GitHub Check: stable - aarch64-unknown-linux-gnu - node@20
GitHub Check: Clippy
GitHub Check: stable - x86_64-unknown-linux-musl - node@20
GitHub Check: Mako Build (macos-latest)
GitHub Check: stable - x86_64-unknown-linux-gnu - node@20
GitHub Check: Mako Build (ubuntu-latest)
GitHub Check: stable - aarch64-apple-darwin - node@20
GitHub Check: Code Coverage
GitHub Check: Cargo Test
GitHub Check: stable - x86_64-apple-darwin - node@20

🔇 Additional comments (2)

crates/mako/src/stats.rs (2)

14-14: 导入语句正确添加！

导入 win_path 函数用于规范化 Windows 路径的处理是合适的。

220-220: 路径处理逻辑已优化！

使用 win_path 函数来规范化路径处理是正确的改进。建议验证代码库中是否还有其他需要类似处理的地方。

运行以下脚本来检查是否存在其他直接转换路径为字符串的情况：

✅ Verification successful

路径处理已经完善！

经过验证，代码库中的路径处理已经恰当实现：

输出路径和模块 ID 已正确使用 win_path 进行规范化

其他路径操作（如内部文件系统操作）使用原生路径格式是合适的
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:
#!/bin/bash
# 描述：查找可能需要使用 win_path 处理的其他路径转换代码

# 搜索 to_str() 或 to_string_lossy() 的调用，这些地方可能也需要路径规范化
rg -A 2 'to_str|to_string_lossy' --type rust

# 搜索路径相关的变量声明
ast-grep --pattern 'let $_ = $_path.to_str()'
Length of output: 34539

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-01-08T06:31:57Z

Walkthrough

This pull request addresses the normalization of Windows paths in the Compiler's output path handling. The change involves using a utility function to ensure paths are correctly formatted for Windows environments.

Changes

File	Summary
crates/mako/src/stats.rs	Added `win_path` function to normalize Windows paths in the output path handling logic.

petercat-assistant · 2025-01-08T06:32:00Z

crates/mako/src/stats.rs

@@ -216,7 +217,7 @@ impl Compiler {
        let abs_path = &self.context.root;
        let output_path = &self.context.config.output.path;
        let dist_path = diff_paths(output_path, abs_path).unwrap_or_else(|| output_path.clone());
-        let mut path_str = dist_path.to_str().unwrap().to_string();
+        let mut path_str = win_path(dist_path.to_str().unwrap());


Ensure that the win_path function handles all edge cases for path normalization, such as trailing slashes or backslashes, to prevent potential path-related errors.

codecov · 2025-01-08T06:38:02Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.81%. Comparing base (66535b5) to head (bcc5973).
Report is 1 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1745      +/-   ##
==========================================
- Coverage   54.81%   54.81%   -0.01%     
==========================================
  Files         180      180              
  Lines       18081    18081              
==========================================
- Hits         9912     9911       -1     
- Misses       8169     8170       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fix: normalize Windows paths in Compiler output path handling

bcc5973

petercat-assistant bot reviewed Jan 8, 2025

View reviewed changes

sorrycc merged commit 7196895 into master Jan 8, 2025
22 checks passed

sorrycc deleted the sorrycc-gki9 branch January 8, 2025 06:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: normalize Windows paths in Compiler output path handling #1745

fix: normalize Windows paths in Compiler output path handling #1745

sorrycc commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

petercat-assistant bot commented Jan 8, 2025

petercat-assistant bot Jan 8, 2025

codecov bot commented Jan 8, 2025 •

edited

Loading

fix: normalize Windows paths in Compiler output path handling #1745

fix: normalize Windows paths in Compiler output path handling #1745

Conversation

sorrycc commented Jan 8, 2025 • edited by coderabbitai bot Loading

Summary by CodeRabbit

coderabbitai bot commented Jan 8, 2025 • edited Loading

概述

演练

变更

可能相关的 PR

诗歌

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

petercat-assistant bot commented Jan 8, 2025

Walkthrough

Changes

petercat-assistant bot Jan 8, 2025

Choose a reason for hiding this comment

codecov bot commented Jan 8, 2025 • edited Loading

Codecov Report

sorrycc commented Jan 8, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jan 8, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jan 8, 2025 •

edited

Loading