Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ determine whether decl is pure #763

Merged
merged 5 commits into from
Dec 8, 2023
Merged

feat: ✨ determine whether decl is pure #763

merged 5 commits into from
Dec 8, 2023

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Dec 8, 2023 •
edited
Loading

利用 may_have_side_effects 判断 var_decl 是否有 side effects。

close #760

e2e: https://github.com/umijs/mako-e2e/pull/34

@stormslowly
Copy link
Member Author

may_have_side_effects 的劣势

  1. 判定过于保守，无 side effects 会判定成有 side effect; 例如赋值语言直接判定成 side effects
  2. 目前还没有支持 PURE 注解

@sorrycc
Copy link
Member

sorrycc commented Dec 8, 2023

需要补个对应的 e2e 用例。

@sorrycc sorrycc merged commit 5c02f58 into master Dec 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/effect_declare branch December 8, 2023 06:42
@stormslowly stormslowly restored the fix/effect_declare branch March 25, 2024 05:24
@stormslowly stormslowly deleted the fix/effect_declare branch August 9, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc sorrycc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

变量声明值有副作用时会被 treeShaking 删除的问题
2 participants
@stormslowly @sorrycc