feat: support to install chunks before entry loaded #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stormslowly
reviewed
Dec 12, 2023
crates/mako/src/chunk_pot/util.rs
Outdated
| <Expr as ExprFactory>::make_bin::<Expr>( | ||
| chunk_global_expr.clone(), | ||
| BinaryOp::LogicalOr, | ||
| quote_ident!("[]").into(), |
There was a problem hiding this comment.
ident 可以 into 成 array expression 吗？
stormslowly
reviewed
Dec 12, 2023
| @@ -314,6 +315,7 @@ const DEFAULT_CONFIG: &str = r#" | |||
| "esVersion": "es2022", | |||
| "meta": false, | |||
| "asciiOnly": true, | |||
| "chunkLoadingGlobal": "", | |||
There was a problem hiding this comment.
我们是不是也叫 namespace 好一点
webpack 也是叫这个名字：https://webpack.js.org/configuration/output/#outputchunkloadingglobal
webpack 的默认值也是 "" 吗？
不是，Mako 和 webpack 一样默认值是根据配置动态计算的
sorrycc
reviewed
Dec 12, 2023
| // globalThis.jsonpCallback([["module_id"], { module object }]) | ||
| let jsonp_callback_stmt = <Expr as ExprFactory>::as_call( | ||
| *member_expr!(DUMMY_SP, globalThis.jsonpCallback), | ||
| // (globalThis['makoChunk_global'] = globalThis['makoChunk_global'] || []).push([["module_id"], { module object }]) |
There was a problem hiding this comment.
globalThis['makoChunk_global'] = 赋值是需要前置加载的 chunk 需要的吧，async chunk 应该不需要。这个优化比较小，如果先不做，可以注释里记个 TODO。
There was a problem hiding this comment.
这里是打算 async chunk 和 shared chunk 用同一套 wrap，不然还得区分两种 chunk 的 runtime wrap
| @@ -314,6 +315,7 @@ const DEFAULT_CONFIG: &str = r#" | |||
| "esVersion": "es2022", | |||
| "meta": false, | |||
| "asciiOnly": true, | |||
| "chunkLoadingGlobal": "", | |||
| @@ -287,6 +288,12 @@ function createRuntime(makoModules, entryModuleId) { | |||
| installedChunks[id] = 0; | |||
| } | |||
| }; | |||
| var chunkLoadingGlobal = global['<%= chunk_loading_global.clone() %>'] = global['<%= chunk_loading_global.clone() %>'] || []; | |||
There was a problem hiding this comment.
这段感觉也是可以按需载入的，如果没有打包出前置加载的 chunk，应该不需要。
sorrycc
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
支持在 entry 之前安装 chunks，该特性是多 entry 功能的改造点之一
实现方案详见 RFC『Runtime 相关』任务：#766