Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dynamicImportToRequire 开启后 没有分析到 import 的依赖 #811

Merged
merged 4 commits into from
Dec 21, 2023
Merged

fix: dynamicImportToRequire 开启后 没有分析到 import 的依赖 #811

merged 4 commits into from
Dec 21, 2023

Conversation

stormslowly
Copy link
Member

主分支用最新 expect 会有以下错误

AssertionError [ERR_ASSERTION]: dynamic imported module(foo) not existss

解

  1. require 补上 unresolve mark applied span
  2. 重构，删除部分函数

@stormslowly stormslowly changed the title fix: ✅ dynamicImportToRequire 没有分析到 import 的依赖 fix: dynamicImportToRequire 开启后 没有分析到 import 的依赖 Dec 21, 2023
@sorrycc sorrycc merged commit df15b03 into master Dec 21, 2023
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/dynamic_import_didnt_change_source branch December 21, 2023 06:14
@stormslowly stormslowly restored the fix/dynamic_import_didnt_change_source branch March 25, 2024 05:24
@stormslowly stormslowly deleted the fix/dynamic_import_didnt_change_source branch August 9, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorrycc sorrycc sorrycc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stormslowly @sorrycc