Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: treats ignore module as normal module #935

Merged
merged 6 commits into from
Mar 6, 2024

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Mar 6, 2024

  1. 将 oxc-resolver 解析出的 ignored module 当 normal module 处理,normal module 的内容固定为 ""。下线原基于 "$$IGNOED$$" 的 ast 替换机制;
  2. 修了几个类型错误 和 clippy 报错。

@xusd320 xusd320 requested review from sorrycc and stormslowly March 6, 2024 06:42
Copy link
Member

@sorrycc sorrycc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file 里的 is_ignore 是不是可以去掉?

@xusd320
Copy link
Contributor Author

xusd320 commented Mar 6, 2024

file 里的 is_ignore 是不是可以去掉?

去掉了 @sorrycc

@sorrycc sorrycc merged commit c7a4d4b into refact/build Mar 6, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the refactor/oxc-resolver-ignore branch March 6, 2024 11:46
@sorrycc sorrycc mentioned this pull request Mar 11, 2024
10 tasks
sorrycc added a commit that referenced this pull request Mar 12, 2024
* refact: build

* update

* update

* runnable

* remove files

* remove task.rs

* remove build.rs

* remove load.rs

* remove parse.rs

* remove transform.rs

* remove md.rs

* remove css.rs

* remove _2 affix

* refact plugins/runtime

* remove meta.rs

* code style

* fix find_export_source test cases

* fix clappy

* fix: bundler-okam don't exit

* fix: build won't end when last module build failed

* fix: css modules support

* fix: css modules

* chore: update

* fix config.platform.node case

* refactor: treats ignore module as normal module (#935)

* refactor: treats ignore module as normal module

* refactor: update LoadError

* fix: typo

* refact: no need to mark ignored on File

* chore: code style

* chore: code style

* fix: optimize.full-helpers testcase

* fix: error.resolve.module-not-found test case

* fix: config.react.runtime.classic testcase

* fix: javascript.require-dynamic testcase

* fix: minifish testcases

* fix: raw_hash calculate when watch is on

* fix: entry with ?hmr

* fix: css modules

* code style

* fix missing related test cases

* code style

* remove missing_deps in module.info

* remove props under module.info

* add inject testcase back

* code style

* add testcases

* update pnpm-lock.yaml

* code style

* code style

* fix: let async imports bundled into separate chunks (#940)

* fix: let async imports bundled into separate chunks

* fix: e2e javascript.require-dynamic

* refact: thread pool (#936)

* refactor: minimum tokio thread pool

* refact: use a static rayon thread pool

* refact: import style

* refact: code style

* refact: import style

---------

Co-authored-by: xusd320 <xusd320@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants