pref: remove regexp external in node_polyfill

[sorrycc]

Close #997

跑 just bench 性能上没明显区别，但应该不需要用到正则。

Summary by CodeRabbit

• Refactor
  • Removed unnecessary debug print statements to clean up console output.
  • Simplified configuration handling in Node polyfills and improved handling of empty modules.

[coderabbitai]

Walkthrough

This update focuses on enhancing the performance and simplification of the Mako build tool. It includes the removal of unnecessary debug print statements in the module concatenation process and streamlines the handling of node polyfills by removing complex external configurations in favor of more straightforward settings. These changes aim to improve the build process's efficiency and maintainability.

Changes

File Path	Change Summary
.../farm_tree_shake/shake/module_concatenate.rs	Removed debug print statements related to configuration and module processing.
.../node_polyfill.rs	Simplified configuration handling by removing advanced external configurations for basic ones.

Assessment against linked issues

Objective	Addressed	Explanation
#997: Default creation of node polyfill externals during external configuration parsing	✅

Poem

In the heart of the code, where the bits softly tread,
A rabbit hopped in, with a clear goal ahead.
🐇💻 To shake the trees, to trim, to prune,
So the build might dance, in the light of the moon.
No longer tangled, in debug's embrace,
It leaps, it bounds, in cyberspace.
"To simplify, to speed," it whispers with glee,
"For a cleaner code world, follow me!" 🌟

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 387a301 and 7e76f96.

Files selected for processing (2)

• crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate.rs (2 hunks)
• crates/mako/src/plugins/node_polyfill.rs (2 hunks)

Files skipped from review due to trivial changes (1)

• crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate.rs

Additional comments: 1

crates/mako/src/plugins/node_polyfill.rs (1)

• 27-32: The simplification of external configurations for empty modules using ExternalConfig::Basic with an empty string is a clear and concise approach. However, it's important to verify that this change does not introduce any unintended side effects, especially in scenarios where these modules or their /promise counterparts might be expected to resolve to non-empty values.

[xusd320]

跑了下 with-antd, 能提升 10% 左右