-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-umi): 为create-umi
新增设置项目名称的步骤
#12516
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Walkthrough本次更改在 Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant setNameFunction as setName Function
participant System
User ->> setNameFunction: Prompt for project name
setNameFunction -->> User: Validate project name
setNameFunction ->> System: Update target based on input
System -->> User: Confirmation of new target
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/create-umi/src/index.ts (2 hunks)
Additional comments not posted (2)
packages/create-umi/src/index.ts (2)
109-125
: 新增的setName
函数看起来不错!该函数通过
clackPrompts
库提示用户输入项目名称,并进行输入验证。代码逻辑清晰且符合预期。
179-184
: 集成的项目名称设置步骤工作良好!该代码段调用了新的
setName
函数,并根据用户输入更新了target
变量,确保项目名称设置步骤正确集成到现有流程中。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/create-umi/src/index.ts (2 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/create-umi/src/index.ts
代码看起来没问题。 改下文档吧,如果不改文档,下一次看文档的人创建就变成 |
|
#10011
为
create-umi
新增了设置项目名称的步骤,默认值为cli传入的第一个参数。Summary by CodeRabbit
setName
功能,提示用户输入项目名称,进行验证,并根据输入更新目标路径。这增强了用户在使用create-umi
工具时的交互体验。