-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support --path
with umi block
#1444
Conversation
Pull Request Test Coverage Report for Build 1975
💛 - Coveralls |
packages/umi-build-dev/src/fixtures/block/alias/routes.js.layout.js
Outdated
Show resolved
Hide resolved
相关问题已改 @yutingzhao1991 |
关于
|
我的想法是:
关于配置式路由按照
cc @sorrycc |
理解了,合并了可以简化一些,只是在 antd pro 中全是相对路径的情况要兼容下。 |
@yutingzhao1991 已合并 layout 和 name 参数,支持正确的目录层级写入。 |
this.skipDependencies = opts.skipDependencies; | ||
this.skipModifyRoutes = opts.skipModifyRoutes; | ||
this.layoutPath = opts.layoutPath; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个应该就不需要了吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的,漏了这一个。
现在有一个潜在问题,像 antd-pro 那种全是相对路径,如果存在同名二级路由,可能会匹配出错。 |
--path
with umi block
@clock157 路径相对和绝对的写法应该都是支持的,不应该影响应该有的逻辑。再单独提 PR 吧。 |
#1438