Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid input map in byte_match_statement #104

Merged
merged 1 commit into from
May 19, 2023
Merged

Fix invalid input map in byte_match_statement #104

merged 1 commit into from
May 19, 2023

Conversation

nunofernandes
Copy link
Contributor

Description

Fixes an invalid input map in the byte_match_statement statement

@Ohid25 Ohid25 merged commit 522081a into umotif-public:main May 19, 2023
@Ohid25 Ohid25 added the bug Something isn't working label May 19, 2023
@Ohid25
Copy link
Contributor

Ohid25 commented May 19, 2023

This is now released as a part of 4.6.1!

@yuvalhnoga
Copy link
Contributor

@Ohid25 @nunofernandes this seems to be a breaking change, also this pr

│ Error: Invalid index
│
│   on ../terraform-aws-waf-webaclv2/main.tf line 6210, in resource "aws_wafv2_web_acl" "main":
│ 6128:                       type     = lookup(byte_match_statement.value["text_transformation"], "type")
│     ├────────────────
│     │ byte_match_statement.value is object with 5 attributes
│
│ The given key does not identify an element in this collection value.

This requires us to change our values and add the text_transformation as a nested value, which is fine but this is a bit weird because this change was not applied everywhere so now there is a difference between each statement in how it accepts the values.

@nunofernandes
Copy link
Contributor Author

@yuvalhnoga let me work on this today and see how can I fix it..

@nunofernandes nunofernandes deleted the nuno/fix-invalid-inputmap-byte_match_statement branch July 11, 2023 10:49
nunofernandes added a commit to nunofernandes/terraform-aws-waf-webaclv2 that referenced this pull request Jul 11, 2023
@nunofernandes
Fix nested required text_transformation and go back to previous beh…
3e24884 
…aviour

After
umotif-public#104, a
bug was introduced that would require a nested `text_transformation`. As
it wasn't done across the entire module, it has different behaviours on
different use-cases.

This fixes that bug and reverts to the previous behaviour.
@nunofernandes nunofernandes mentioned this pull request Jul 11, 2023
Merged
@nunofernandes
Copy link
Contributor Author

Just created #113 to fix that..

Ohid25 pushed a commit to nunofernandes/terraform-aws-waf-webaclv2 that referenced this pull request Jul 18, 2023
@nunofernandes
Fix nested required text_transformation and go back to previous beh…
41d2263 
…aviour

After
umotif-public#104, a
bug was introduced that would require a nested `text_transformation`. As
it wasn't done across the entire module, it has different behaviours on
different use-cases.

This fixes that bug and reverts to the previous behaviour.
Ohid25 pushed a commit that referenced this pull request Jul 18, 2023
@nunofernandes
Fix nested required text_transformation and go back to previous beh…
9d75cc2 
…aviour (#113)

After
#104, a
bug was introduced that would require a nested `text_transformation`. As
it wasn't done across the entire module, it has different behaviours on
different use-cases.

This fixes that bug and reverts to the previous behaviour.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ohid25 Ohid25 Ohid25 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunofernandes @Ohid25 @yuvalhnoga