Adding forwarded_ip_config for ip_set. Added regex_set for AND Not Statement. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt (umotif-public#60)" This reverts commit e531012.
This reverts commit db221d7.
* Added support for Regex Match Statements * Lint and other fixes Co-authored-by: Tomasz Rychlewicz <tomasz.rychlewicz@explaineverything.com>
Ohid25
approved these changes
Jan 25, 2023
Ohid25
pushed a commit
to surendhar-kodaikal-palani/terraform-aws-waf-webaclv2
that referenced
this pull request
Jan 25, 2023
…atement. (umotif-public#65) * Add forwarded_ip_config for ip_set. Added regex_set for AND NOT Statement. * Adding examples. * Correcting dynamic ip_set_forwarded * Correct ip_set example * Revert "feat: add label_match_statement to managed_rule_group_statement (umotif-public#60)" This reverts commit e531012. * Revert "Correct ip_set example" This reverts commit db221d7. * Updating sizeconstraint rule to have oversizehandling for body. * Correction to use equals sign. * Small corrections to sizeconstraint rule. * Updating to meeting requirements of fix to terraform provider. * Added support for Regex Match Statements (umotif-public#63) * Added support for Regex Match Statements * Lint and other fixes Co-authored-by: Tomasz Rychlewicz <tomasz.rychlewicz@explaineverything.com> * Remove oversize_handling from body until 4.52 release hashicorp/terraform-provider-aws#29082 * Lint fixes Co-authored-by: ndugera <ndugera@payfone.com>
|
Part of the 4.0.0 release! Thank you for your contribution! |
|
@Ohid25 @DugeraProve why did you remove these lines from the I have added this as part of this pr but now I am unable to upgrade my WAF module version because you removed it. |
|
@yuvalhnoga apologies I'm unclear how I made this commit a31bec1. It was unrelated to features I was adding and I do not recall making these changes. This was done in error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.