Fix yt-dlp output filename template

[rantanevich]

After upgrading yt-dlp, the target file name is generated as -o {{.Filename}}.tmp + .mp3

$ pip3 freeze | grep yt-dlp
yt-dlp==2023.2.17

$ yt-dlp --extract-audio --audio-format=mp3 --audio-quality=0 -f m4a/bestaudio "https://www.youtube.com/watch?v=hhvNl2a04aM" --no-progress -o 4f92358fcd37f1e117962be5ab69f02cda651d4c.tmp
[youtube] Extracting URL: https://www.youtube.com/watch?v=hhvNl2a04aM
[youtube] hhvNl2a04aM: Downloading webpage
[youtube] hhvNl2a04aM: Downloading android player API JSON
[info] hhvNl2a04aM: Downloading 1 format(s): 140
[download] Destination: 4f92358fcd37f1e117962be5ab69f02cda651d4c.tmp
[download] Download completed
[FixupM4a] Correcting container of "4f92358fcd37f1e117962be5ab69f02cda651d4c.tmp"
[ExtractAudio] Destination: 4f92358fcd37f1e117962be5ab69f02cda651d4c.tmp.mp3
Deleting original file 4f92358fcd37f1e117962be5ab69f02cda651d4c.tmp (pass -k to keep)

But we expect to get {{.Filename}}.mp3 that leads to skipping new entries

feed-master/app/youtube/feed/downloader.go

Lines 70 to 73 in 0bd1310

	file = filepath.Join(d.destination, fname+".mp3")
	if _, err := os.Stat(file); os.IsNotExist(err) {
	return file, ErrSkip
	}

[umputun]

The problem was discussed, and the issue is real. However, the fix you are proposing is not fixing it. It changes a test and a comment but won't change the behavior. Still, it is good to have for consistency; however, to fix it, the user needs to adjust yml configuration and get rid of .tmp suffix.

I have updated provided yml files in the example and the documentation; see c96f4f1

[rantanevich]

My fault I didn't update default value in ./app/config/config.go. So it would allow not to specify c.YouTube.DlTemplate in the config

feed-master/app/config/config.go

Lines 169 to 171 in 9be6959

	if c.YouTube.DlTemplate == "" {
	c.YouTube.DlTemplate = `yt-dlp --extract-audio --audio-format=mp3 --audio-quality=0 -f m4a/bestaudio "https://www.youtube.com/watch?v={{.ID}}" --no-progress -o {{.FileName}}.tmp`
	}

Should I preparer a new PR or you will fix it yourself?