Improve getMessageHTML signature, improve telegram message crop #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/telegram_improvements
branch
3 times, most recently
from
60af1e3 to
37f5979
Compare
Previously, the telegram message was stripped of its HTML, which was unintended. After that change, it would be stripped of HTML formatting only if the characters limit is exceeded. Otherwise, we need to do sophisticated HTML parsing to find the tag, which would be left without the closing part when trimming the message.
paskal
force-pushed
the
paskal/telegram_improvements
branch
from
37f5979 to
742c372
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on review notes from #52. Can be merged after #55.
Previously, the telegram message was stripped of its HTML, which was unintended. After that change, it would be stripped of HTML formatting only if the characters limit is exceeded. Otherwise, we need to do sophisticated HTML parsing to find the tag, which would be left without the closing part when trimming the message.