Add media:thumbnail and itunes:image to generated rss feeds

[orthur]

PR for #64

[umputun]

we shouldn't form this image URL automatically but rather conditionally from s.Conf.Feeds[feedName].Image (if not empty)

[orthur]

got it, fixed

[umputun]

almost ;) the image url should be baseURL+s.Conf.Feeds[feedName].Image instead of generic baseURL + "/image/" + feedName

[orthur]

ah got it now

[umputun]

Thx, looking good.

As we touched RSS output, could you pls add a test checking generated RSS, with and without images

[orthur]

Ok will add

[orthur]

@umputun could you please guide me to the right direction with tests? since there are no existing tests for generated feeds, do I have to create tests for handler getFeedCtrl ? I would have to create test config file, test db and test server?

And it would look something like that:

// setup test db, config, server
req, _ := http.NewRequest("GET", "/rss/echo-msk", nil)
rr := httptest.NewRecorder()
s.MountHandlers(8080)
s.httpServer.Handler.ServeHTTP(rr, req)
// do checks for rr.Body

[umputun]

in fact this server wasn't too testable. I have added ctx param to Run so the integration test could terminate it and extracted router() func, so you could pass it into httptest.Server

regarding the test itself - all you need to start it to make a testing boltdb and config filled with whatever you need and pass it in.

After this, you can call bolt's save for several records and should be good to go.

so, your test would look like:

  	tmpfile := filepath.Join(os.TempDir(), "test.db")
	defer os.Remove(tmpfile)
	db, err := bolt.Open(tmpfile, 0o600, &bolt.Options{Timeout: 1 * time.Second})
	require.NoError(t, err)
	boltStore := &proc.BoltDB{DB: db}

        conf := config.Conf{.....}
        srv := Server{Store: boltStore, Conf: conf}
        ts := httptest.Server(srv.router())
        defer  ts.Close()

From this point, you could send the real http request to ts.URL + "/whatever" and check the response

hope it helps

[orthur]

that helps, thanks

[umputun]

wanna me to merge this pr as-is and you could add test(s) in the following pr?

[orthur]

yes lets do that