Add include and exclude filters for youtube feed #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umputun
requested changes
Apr 24, 2022
| boltStore := &store.BoltDB{DB: db} | ||
| svc := Service{ | ||
| Feeds: []FeedInfo{ | ||
| {ID: "channel1", Name: "name1", Type: ytfeed.FTChannel, Filter: FeedFilter{Include: "Prefix2", Exclude: "title3"}}, |
There was a problem hiding this comment.
I'd suggest adding a case with some regex filters. Maybe for channel2 in addition to the current one
app/youtube/service.go
Outdated
| @@ -346,6 +363,30 @@ func (s *Service) isNew(entry ytfeed.Entry, fi FeedInfo) (ok bool, err error) { | |||
| return true, nil | |||
| } | |||
|
|
|||
| // isRelevant checks if entry matches all filters for the channel feed | |||
| func (s *Service) isRelevant(entry ytfeed.Entry, fi FeedInfo) (ok bool, err error) { | |||
There was a problem hiding this comment.
I'm not sure the name of the function communicating the intent well. This one is not about relevance, but rather filtering, i.e. isFiltered or isAllowed or smth like this
README.md
Outdated
| @@ -55,10 +55,11 @@ youtube: # youtube configuration, optional | |||
| rss_location: ./var/rss # location for generated youtube channel's RSS | |||
| channels: # list of youtube channels to download and process | |||
| # id: channel or playlist id, name: channel or playlist name, type: "channel" or "playlist", | |||
| # lang: language of the channel, keep: override default keep value | |||
| # lang: language of the channel, keep: override default keep value | |||
| # filter: criteria to include and exclude videos | |||
There was a problem hiding this comment.
i would add "can be regex" part
|
Pushed fixes for all comments |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #89
This is my first real Go project so ready for comments.
Also I'm not sure which counter in
allStatsI should increment in this case so incrementedignored.