Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check /status before getting user details #1752

Closed
wants to merge 0 commits into from

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Mar 16, 2024

Resolves #1188 at the cost of one extra /auth/status call for authorised users and replacing /API/v1/user call with /auth/status for unauthorised users.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 61.39%. Comparing base (e1173bb) to head (d432667).
Report is 9 commits behind head on master.

Files Patch % Lines
frontend/apps/remark42/app/common/api.ts 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1752      +/-   ##
==========================================
- Coverage   61.47%   61.39%   -0.09%     
==========================================
  Files         132      132              
  Lines        2998     3002       +4     
  Branches      715      716       +1     
==========================================
  Hits         1843     1843              
- Misses       1151     1155       +4     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Mar 16, 2024

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (0%)
public/remark.mjs 73.47 KB (+0.03% 🔺)
public/remark.css 8.26 KB (+0.02% 🔺)
public/last-comments.mjs 35.72 KB (0%)
public/last-comments.css 3.75 KB (0%)
public/deleteme.mjs 12.09 KB (+0.16% 🔺)
public/counter.mjs 751 B (0%)

@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
@paskal paskal requested a review from Mavrin March 16, 2024 20:41
@paskal paskal force-pushed the paskal/improve_get_user branch from 0a2df84 to 06ace62 Compare March 16, 2024 21:36
Mavrin
Mavrin previously approved these changes Mar 16, 2024
@paskal paskal marked this pull request as draft March 16, 2024 21:56
@paskal paskal force-pushed the paskal/improve_get_user branch from 06ace62 to abe5c51 Compare March 16, 2024 21:57
Mavrin
Mavrin previously approved these changes Mar 16, 2024
@paskal paskal force-pushed the paskal/improve_get_user branch 3 times, most recently from 817d088 to d432667 Compare March 16, 2024 22:24
@paskal paskal closed this Apr 10, 2024
@paskal paskal force-pushed the paskal/improve_get_user branch from d432667 to e0423b8 Compare April 10, 2024 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Experience/Core Web Vitals: Browser errors were logged to the console
2 participants