`#local` `imports` paths being recognized in `no-unassigned-import` config

[fregante]

Code:

import "#app/side-effects.js"

Config:

"import-x/no-unassigned-import": [
  "error",
  {
    allow: [
      "**/*.css",
      "**/*.scss",
      "#app/side-effects.js",
    ]
  }
]

Error:

  1:1  error  Imported module should be assigned  import-x/no-unassigned-import

#208 reportedly added support for these paths but not here. eslint-plugin-import is also affected.

Workaround:

"import-x/no-unassigned-import": [
  "error",
  {
    allow: [
      "**/*.css",
      "**/*.scss",
-     "#app/side-effects.js",
+     "*app/side-effects.js",
    ]
  }
]

[petercat-assistant]

The issue you're encountering is related to the no-unassigned-import rule in the eslint-plugin-import-x configuration. It seems that the #local import paths are not being recognized correctly, even though support for these paths was reportedly added in a previous update (issue #208).

Problem:

The configuration you provided should allow the import of #app/side-effects.js without triggering an error. However, the rule still flags it as an error, indicating that the imported module should be assigned.

Workaround:

You've already found a workaround by changing the path from #app/side-effects.js to *app/side-effects.js in the allow list. This seems to bypass the issue.

Next Steps:

1. Verify Configuration: Double-check that the configuration is correctly applied and that there are no overrides elsewhere in your ESLint setup.
2. Check for Updates: Ensure that you are using the latest version of eslint-plugin-import-x, as there might have been updates or fixes related to this issue.
3. Report the Issue: If the problem persists, consider reporting it on the GitHub repository if it hasn't been addressed yet. You can reference the previous issue Replacing the built-in default import resolver that supports exports and imports from package.json #208 for context.

If you need further assistance or would like to explore more about this issue, feel free to ask!

🪧 Tips

For further assistance, please describe your question in the comments and @petercat-assistant to start a conversation with me.

[JounQin]

exports and imports are only available with the new node resolver or https://github.com/import-js/eslint-import-resolver-typescript yet, please provide more info including runnable reproduction.

We're also aiming to fix it with #272.

[JounQin]

It has nothing to do with exports/imports actually, it's glob's semantic:

https://github.com/isaacs/minimatch#comparisons-to-other-fnmatchglob-implementations

If a pattern starts with #, then it is treated as a comment, and will not match anything. Use \# to match a literal # at the start of a line, or set the nocomment flag to suppress this behavior.

That's being said, it's easy enough to enable nocomment option for this case like other places, see #352 for more details.