Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release eslint-plugin-import-x #126

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Conversation

github-actions[bot]
Copy link

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

eslint-plugin-import-x@4.0.0

Major Changes

  • #112 4ba14da Thanks @SukkaW! - Use typescript-eslint v8. The minimum supported ESLint version is now >= 8.57.0 and the minimum required Node.js version is now 18.18.0.

Copy link

codesandbox-ci bot commented Aug 14, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@SukkaW
Copy link
Collaborator

SukkaW commented Aug 14, 2024

I wonder if we should include flat config presets in this major release or not. We can probably split #122 into 2 PRs.

@merrywhether
Copy link

merrywhether commented Aug 14, 2024

I wonder if we should include flat config presets in this major release or not. We can probably split #122 into 2 PRs.

Switching to ts-eslint v8 is seemingly a major change but adding flat config support is only a minor one (unless you drop legacy config compat entirely), so from that perspective they don't need to be coupled. It's definitely easier to work around supporting legacy configs with the helpers than it is this dependency (which requires overrides).

@SukkaW SukkaW merged commit f37dc29 into master Aug 26, 2024
1 check passed
@SukkaW SukkaW deleted the changeset-release/master branch August 26, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants