-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for using resolver object directly in settings #159
Conversation
🦋 Changeset detectedLatest commit: 2ab6a20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #159 +/- ##
==========================================
- Coverage 96.22% 96.01% -0.21%
==========================================
Files 91 101 +10
Lines 4399 4670 +271
Branches 1497 1601 +104
==========================================
+ Hits 4233 4484 +251
- Misses 160 180 +20
Partials 6 6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry for the late reply. I like this change very much! I have added only a small review suggestion, and I have approved the CI to run. We can ship this as long as all existing test cases are passed. Another thought, would you mind adding a test case for your change as well? So that we can test against the new config. |
I have added test cases and reorganized the test set. Could you please approve running CI again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
close #75