Skip to content

Commit

Permalink
ci: no need to run build twice
Browse files Browse the repository at this point in the history
  • Loading branch information
JounQin committed Aug 29, 2021
1 parent ee49d5c commit cff7187
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 11 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,8 @@ jobs:

- name: Build, Lint and test
run: |
yarn build
yarn lint
yarn test
yarn lint
env:
EFF_NO_LINK_RULES: true
PARSER_NO_WATCH: true
Expand Down
2 changes: 1 addition & 1 deletion .lintstagedrc.cjs
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = require('@1stg/lint-staged')
module.exports = require('@1stg/lint-staged/tsc')
6 changes: 3 additions & 3 deletions benchmarks/benchmark.cjs.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ $ node benchmarks/benchmark.cjs
┌───────────┬────────────┬──────────────┬───────────────────┬────────────┬────────────────┬───────────┬─────────────────┐
│ (index) │ synckit │ sync-threads │ perf sync-threads │ deasync │ perf deasync │ native │ perf native │
├───────────┼────────────┼──────────────┼───────────────────┼────────────┼────────────────┼───────────┼─────────────────┤
│ loadTime │ '26.45ms' │ '1.61ms' │ '16.47x slower' │ '15.39ms' │ '1.72x slower' │ '0.35ms' │ '76.64x slower' │
│ runTime │ '256.15ms' │ '4884.80ms' │ '19.07x faster' │ '428.31ms' │ '1.67x faster' │ '35.98ms' │ '7.12x slower' │
│ totalTime │ '282.60ms' │ '4886.41ms' │ '17.29x faster' │ '443.70ms' │ '1.57x faster' │ '36.32ms' │ '7.78x slower' │
│ loadTime │ '13.13ms' │ '2.05ms' │ '6.42x slower' │ '9.73ms' │ '1.35x slower' │ '0.45ms' │ '29.50x slower' │
│ runTime │ '288.46ms' │ '6167.96ms' │ '21.38x faster' │ '323.32ms' │ '1.12x faster' │ '44.70ms' │ '6.45x slower' │
│ totalTime │ '301.59ms' │ '6170.01ms' │ '20.46x faster' │ '333.06ms' │ '1.10x faster' │ '45.15ms' │ '6.68x slower' │
└───────────┴────────────┴──────────────┴───────────────────┴────────────┴────────────────┴───────────┴─────────────────┘
6 changes: 3 additions & 3 deletions benchmarks/benchmark.esm.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ $ node benchmarks/benchmark.js
┌───────────┬────────────┬──────────────┬───────────────────┬────────────┬────────────────┬───────────┬─────────────────┐
│ (index) │ synckit │ sync-threads │ perf sync-threads │ deasync │ perf deasync │ native │ perf native │
├───────────┼────────────┼──────────────┼───────────────────┼────────────┼────────────────┼───────────┼─────────────────┤
│ loadTime │ '41.02ms' │ '1.93ms' │ '21.31x slower' │ '14.68ms' │ '2.80x slower' │ '0.78ms' │ '52.48x slower' │
│ runTime │ '278.47ms' │ '4819.02ms' │ '17.31x faster' │ '420.87ms' │ '1.51x faster' │ '38.73ms' │ '7.19x slower' │
│ totalTime │ '319.49ms' │ '4820.94ms' │ '15.09x faster' │ '435.55ms' │ '1.36x faster' │ '39.51ms' │ '8.09x slower' │
│ loadTime │ '29.26ms' │ '2.26ms' │ '12.92x slower' │ '17.44ms' │ '1.68x slower' │ '1.02ms' │ '28.72x slower' │
│ runTime │ '286.99ms' │ '5520.70ms' │ '19.24x faster' │ '398.49ms' │ '1.39x faster' │ '47.83ms' │ '6.00x slower' │
│ totalTime │ '316.24ms' │ '5522.96ms' │ '17.46x faster' │ '415.93ms' │ '1.32x faster' │ '48.85ms' │ '6.47x slower' │
└───────────┴────────────┴──────────────┴───────────────────┴────────────┴────────────────┴───────────┴─────────────────┘
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"lint:tsc": "tsc --noEmit",
"prepare": "simple-git-hooks && yarn-deduplicate --strategy fewer || exit 0",
"prerelease": "npm run build",
"pretest": "yarn build:ts",
"pretest": "yarn build",
"release": "clean-publish && changeset publish",
"test": "yarn jest",
"typecov": "type-coverage"
Expand Down Expand Up @@ -103,7 +103,7 @@
]
},
"typeCoverage": {
"atLeast": 99.2,
"atLeast": 99.42,
"cache": true,
"detail": true,
"ignoreAsAssertion": true,
Expand Down

0 comments on commit cff7187

Please sign in to comment.