Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for EOL Python 2.6 and 3.2-2.4 #87

Merged
merged 4 commits into from
Oct 14, 2019
Merged

Conversation

hugovk
Copy link
Contributor

@hugovk hugovk commented Oct 13, 2019

Python 2.6 and 3.3 were removed in #63, so this removes their Trove classifiers.

This also:

  • Removes a duplicate test class

  • Upgrade Python syntax with pyupgrade

  • Upgrade PyPy and PyPy3 (6.0.0 to 7.1.1) and test 3.8 beta on the CI

  • Add python_requires to help pip

@un33k
Copy link
Owner

un33k commented Oct 14, 2019

@hugovk. May I ask you to raise the PR against the staging branch instead ? Thank you.

@hugovk hugovk changed the base branch from master to staging October 14, 2019 20:57
@hugovk
Copy link
Contributor Author

hugovk commented Oct 14, 2019

I've switched the base branch to staging.

May I suggest changing the default branch in the repo settings to staging? That way future PRs will be made to staging in the future. Thanks!

@un33k
Copy link
Owner

un33k commented Oct 14, 2019

I like master branch as default, but I wish there was a way to include a default branch for incoming PRs. Each incoming PR needs to be tested followed by a version bump and only then it can be promoted to master and pushed to pypi.

@un33k un33k merged commit 588372d into un33k:staging Oct 14, 2019
@hugovk hugovk deleted the rm-eol branch October 14, 2019 21:30
un33k added a commit that referenced this pull request Oct 20, 2019
* Drop support for EOL Python 2.6 and 3.2-2.4 (#87)

* Drop support for EOL Python 2.6 and 3.2-3.4

* Remove duplicate class

* Upgrade Python syntax with pyupgrade

* Upgrade PyPy and PyPy3 and test 3.8 beta

* up version
@un33k
Copy link
Owner

un33k commented Oct 20, 2019

Thank you for your contribution. Version 4.0.0 is pushed. https://github.com/un33k/python-slugify/tree/4.0.0

@hugovk
Copy link
Contributor Author

hugovk commented Oct 20, 2019

You're welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants