Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis #222

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add travis #222

wants to merge 1 commit into from

Conversation

lislis
Copy link

@lislis lislis commented Oct 6, 2016

Hey @una!

I took the liberty to add a .travis.yml mentioned in this issue #168

The current configuration runs gulp lib-scss and gulp sass-lint on Node versions 4, 5 and 6.
Let me know if you need these configurations changed.

I'd also add a Gulp task that builds the site but doesn't use browser sync/ opens a browser. wdyt?

@una
Copy link
Owner

una commented Oct 8, 2016

the start script is just gulp for building the site out -- whats the benefit of Travis here?

@lislis
Copy link
Author

lislis commented Oct 10, 2016

Hey @una and sorry for the delayed reply!
The command gulp builds the site and tries to open/ sync a browser (If I read the Gulpfile correctly). We can't exactly do that in Travis.
But we can test if the scss builds (or the twig templates for that matter) to detect errors without checking the page locally.
Is that something you'd be interested in having at all? I figured I just start somewhere after I saw the open ticket. But if you don't feel free to just close the PR :)

@una
Copy link
Owner

una commented Oct 10, 2016

Yeah definitely, I'm just trying to get some more context and learn a bit more about it 😄 I think this is definitely a good idea!

@lislis
Copy link
Author

lislis commented Oct 11, 2016

Let me know if you need more information. I can also add some comments if that helps :)

@@ -0,0 +1,15 @@
sudo: required
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is sudo required here?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question! The Travis docs state that to compile NodeJS v4 or later a newer C++ compiler is needed.
That compiler is currently available in images that also allow sudo rights in your build.
So while we don't need sudo explicitly we need the build image that offers it.
Does that make sense?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants