-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev build #242
Dev build #242
Conversation
Such a good update -- I think a few files got in there accidentally! |
There are few issues with current master:
So the last commit in this PR c38b629 is a cleanup for those:
That is why those files are there. Sorry to mix up everything together! 😓 |
c38b629
to
f89a889
Compare
f183beb
to
726e5d5
Compare
@@ -92,7 +92,7 @@ | |||
}, | |||
{ | |||
"name": "Kelvin", | |||
"is_done": false, | |||
"is_done": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file from the PR?
@@ -1,38 +0,0 @@ | |||
/* | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file too got in here somehow!
Yay! Awesome! |
Implementation for #239 😄
In summary,
(I removed compiled files of Amaro filter which is currently unavailable. Also did reset for Kelvin filter
is_done
status, it had got reset in one of the previous commits. Sorry to keep it in the same PR.)