Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spawn new workers if backlog is > 0 for some time #109

Merged
merged 1 commit into from
Jan 26, 2013
Merged

spawn new workers if backlog is > 0 for some time #109

merged 1 commit into from
Jan 26, 2013

Conversation

prymitive
Copy link
Contributor

With this patch cheaper busyness algo will check if backlog is > 0 for too long, if so it will spawn additional worker(s).
This patch tries to address this case:

  • user starts app with 2 workers (cheaper=2, workers=16)
  • app gets to "heavy" requests that take long time to process
  • until at least one of those requests is finished all new requests will be kept in backlog
  • depending on how user configured busyness algo it is possible that if requests in backlog are there for too long they might get timed out

@prymitive
Copy link
Contributor Author

This one is simple, tested (I'm running uWSGI with this patch since 2 weeks) and it does it's job properly.
It really helps when running with just few workers.

@unbit
Copy link
Owner

unbit commented Jan 26, 2013

can you re-make the pull request ? (even if i do not get why i cannot merge it...)

unbit added a commit that referenced this pull request Jan 26, 2013
spawn new workers if backlog is > 0 for some time
@unbit unbit merged commit f81ea8e into unbit:master Jan 26, 2013
@prymitive
Copy link
Contributor Author

I was about to commit cosmetic fix ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants