Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new options to control worker minimum and maximum lifetime #125

Merged
merged 1 commit into from
Jan 26, 2013
Merged

new options to control worker minimum and maximum lifetime #125

merged 1 commit into from
Jan 26, 2013

Conversation

prymitive
Copy link
Contributor

No description provided.

@prymitive
Copy link
Contributor Author

I just realized that --max-worker-lifetime will only work if master is enabled. Should I add some code for cases with no running master?

@unbit
Copy link
Owner

unbit commented Jan 21, 2013

just enable the master automatically if it is specified (UWSGI_OPT_MASTER flag)

@prymitive
Copy link
Contributor Author

I mean that this code will only be executed if master is running:
https://github.com/unbit/uwsgi/pull/125/files#L1R1209

But there are other options like --evil-reload-on-rss that will also work only with master enabled so I think that we just need to make that clear in some way that master is required. Either in uWSGI docs, or in uwsgi --help output. If this is common that some options require master process than maybe we could add new flag to option definition? If flag is on --help would also print that it requires master, for example:

--min-worker-lifetime   number of seconds worker must run before being reloaded (default is 60)
--max-worker-lifetime  reload workers after the specified amount of seconds (default is disabled) [M]

where [M] would mean that master is required. We could have other flags there to show other informations like default values.

Do You mean I should just force master when max-worker-lifetime is enabled?

unbit added a commit that referenced this pull request Jan 26, 2013
new options to control worker minimum and maximum lifetime
@unbit unbit merged commit 15f0f8d into unbit:master Jan 26, 2013
@prymitive prymitive deleted the worker_lifetime branch January 26, 2013 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants