refactored legion opt functions to be more plugin friendly #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unbit
added a commit
that referenced
this pull request
Mar 30, 2013
refactored legion opt functions to be more plugin friendly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that I've managed not to break it (at least simple legion setups still works just fine), but please review and post any changes you want.
Also I've noticed that in original opt function
char *legionis not always freed at the end, I saw only one comment inuwsgi_opt_legion_scroll()that it should not be freed. Please verify it we free it every time we should.As always naming will probably need refactoring, just let me know.