Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds ability to control what values (if any) for avg_rt will be sent if ... #213

Merged
merged 1 commit into from
Apr 5, 2013
Merged

adds ability to control what values (if any) for avg_rt will be sent if ... #213

merged 1 commit into from
Apr 5, 2013

Conversation

prymitive
Copy link
Contributor

...no requests were done, fixes #212

I did basic testing and it looks ok, please review

Usage:

--carbon-idle-avg none - don't push any avg_rt value if no requests were made
--carbon-idle-avg last - use last computed avg_rt value (default)
--carbon-idle-avg zero - push 0 if no requests were made

@unbit
Copy link
Owner

unbit commented Apr 5, 2013

i am not sure to understamd the problem here, it is better to not send avg when it is zero ?

@prymitive
Copy link
Contributor Author

if you want to accurately average some metrics than you want only those metrics, if there are no requests than sending zero will move average values toward zero.

Example: during 10 minutes you only have 2 requests serviced in 1 second each, so we should have 1s (1+1/2) avg_rt average, but sending zeros will gives us 0.2s (1+1/10).

Number of samples counts in average computation, so we should not send any metrics for time periods with no requests

unbit added a commit that referenced this pull request Apr 5, 2013
adds ability to control what values (if any) for avg_rt will be sent if ...
@unbit unbit merged commit 9b8646a into unbit:master Apr 5, 2013
@prymitive prymitive deleted the carbon_avg_policy branch April 5, 2013 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't send avg_rt to carbon if no requests have been serviced
2 participants