Fix reload-on-touch/change #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of a fix for unbit#2656, commit 8f1d0e5 introduced a measure to wait for processes to finish work while reloading. The code to do this affects other logic flows was well, breaking the ability to reload uwsgi when a config file changes. This moves the code around a bit so unbit#2656 stays fixed, but reload-on-touch/change works again. Fixes unbit#2681.
xrmx
reviewed
Oct 26, 2024
xrmx
reviewed
Oct 26, 2024
xrmx
reviewed
Oct 26, 2024
|
Thanks a lot! |
xrmx
added a commit
to xrmx/uwsgi
that referenced
this pull request
Oct 26, 2024
* Fix reload-on-touch/change As part of a fix for unbit#2656, commit 8f1d0e5 introduced a measure to wait for processes to finish work while reloading. The code to do this affects other logic flows was well, breaking the ability to reload uwsgi when a config file changes. This moves the code around a bit so unbit#2656 stays fixed, but reload-on-touch/change works again. Fixes unbit#2681. * Apply suggestions from code review --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
|
Thank you very much for this! This change has fixed my spoolers not being killed (staying in defunct state), while trying to do a touch-reload. It resulted in my entire uwsgi stack hanging on reload. |
This was referenced Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of a fix for #2656, commit 8f1d0e5 introduced a measure to wait for processes to finish work while reloading. The code to do this affects other logic flows was well, breaking the ability to reload uwsgi when a config file changes.
This moves the code around a bit so #2656 stays fixed, but reload-on-touch/change works again.
Fixes #2681.