Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't alert user on worker restarts caused by hitting max requests #46

Closed
wants to merge 1 commit into from
Closed

don't alert user on worker restarts caused by hitting max requests #46

wants to merge 1 commit into from

Conversation

prymitive
Copy link
Contributor

When worker restarts due to hitting request limit uWSGI generates warning that might be confusing to users since it looks like something bad has happened while everything is under control:

Nov  7 22:01:42 localhost app: ...The work of process 99 is done. Seeya!
Nov  7 22:01:43 localhost app: DAMN ! worker 1 (pid: 99) MISTERIOUSLY died :( trying respawn ...
Nov  7 22:01:43 localhost app: Respawned uWSGI worker 1 (new pid: 111)

With this patch uWSGI handles such condition and doesn't show any warning:

Nov  7 22:03:26 localhost app: ...The work of process 99 is done. Seeya!
Nov  7 22:03:27 localhost app: Respawned uWSGI worker 1 (new pid: 111)

@prymitive
Copy link
Contributor Author

Maybe there is more obvious way to detect such restarts, but it seems that master doesn't mark worker in any specific way during restart so I'm using delta_request. I'm not sure if this is 100% correct way.

@unbit
Copy link
Owner

unbit commented Nov 8, 2012

it is a bug in the condition (it should check for termination signal as the "misterious" death). HEAD should be fixed

@prymitive
Copy link
Contributor Author

It works with latest master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants