Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop calling each plugins master_cycle() when uWSGI is stopping or reloading #72

Closed
wants to merge 1 commit into from
Closed

Conversation

prymitive
Copy link
Contributor

I'm not sure if this is needed but if calling master_cycle() in plugin is blocking master, than we should disable those calls once we know uWSGI is shutting down. This way we can have faster stop/reload - or at least we minimize the risk of hanging there (if there is any).
It looks like to_hell means shutting down and to_heaven means reloading so I used those.
For Your consideration.

@prymitive
Copy link
Contributor Author

I wanted to cleanup my open issues - is this one mergeable? I'm not sure if this is really needed but it might be useful.

@prymitive
Copy link
Contributor Author

This could be useful for plugins like distributed crons - if we now we are stopping we should stop executing tasks

@unbit
Copy link
Owner

unbit commented Jun 14, 2013

i am not if it is still an issue (5 months elapsed). We moved the carbon plugin to the "stats pusher api"

@prymitive
Copy link
Contributor Author

let's close it, there are not obvious benefits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants