Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 7.2.1 #1929

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Rails 7.2.1 #1929

wants to merge 3 commits into from

Conversation

EGiataganas
Copy link
Member

Description of change

Rails 7.2.1

Story Link

https://trello.com/c/ZAd8mStM

@benjamineskola
Copy link
Contributor

benjamineskola commented Aug 27, 2024

It looks like we have a very old version of activerecord-postgis-adapter: 3.1.2 when the current is 9.0.2. I'm not sure why we have that version, which is older than BOPS itself, but I think this is the cause of the "uninitialised constant" errors.

However, the latest version (9.0.2) only supports Rails 7.1, so we'll need to wait for them to release a new version before we can update to Rails 7.2.

@EGiataganas
Copy link
Member Author

Yes I am aware of that, there's an open issue on the activerecord-postgis-adapter gem. Last month they merged a PR but it looks like is still not fully supported. So it will need to wait

@benjamineskola
Copy link
Contributor

Yep, just found the same; it looks like we could depend on the github version:

gem "activerecord-postgis-adapter", github: "rgeo/activerecord-postgis-adapter"

But I suggest waiting for an actual release unless we consider this upgrade urgent.

open-pull-requests-limit: 0 # security only
- package-ecosystem: "docker"
interval: daily
open-pull-requests-limit: 10 # security only
Copy link
Contributor

@benjamineskola benjamineskola Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we're changing this limit we should remove the comment, as it's no longer accurate: 0 means only security-related updates, anything > 0 means all updates. (I missed this on bops-applicants.)

@EGiataganas EGiataganas marked this pull request as draft August 27, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants