Beta 2 More Feedback Improvements and Tests #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use single db query and python loops to get all users to populate who is on what manuscript Switch manuscripts page name Switch filter code to now search all columns for username as multi column searching is ugly in datatables
Makes it more obvious what is going on Also, disable user filter table as it is unused and unweildy
Does not change across pages / searches Did not set submission or user table
Fix file datatable error when not showing newness column
Access assertions are disabled Also: Correct clean up selenium instances during tearDown Fix ! point color Minor button improvements for testing
We test admin functionality in our other tests already This switch uncovered test parts that were using the curator admin when they should have been other roles
Fix incorrect test invites Fix submission file datatable being visible to non authors when author is working on it TODO: - Add complete tests for previous submissions - Manually test the file_table change and improve - Rerun old tests, probably broken from above as well
Fix tests related to file_table Fix minor issues other tests
Rename some previous submission test arrays
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.