chore: test todo action

uncefact · Jun 28, 2023 · 2faf9dc · 2faf9dc
1 parent 1df2a18
commit 2faf9dc
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/packages/cli/default/default.yml b/packages/cli/default/default.yml
@@ -174,6 +174,16 @@ didResolver:
       sov:
         $ref: /universal-resolver
 
+#  TODO: remove hardcoded infura project ID
+
+#  this is referencing someone else's infura project that could
+#  be shut down at any point, breaking any functionality that requires
+#  eth interactions. 
+
+#  worth searching the rest of the codebase at the same time as 
+#  fixing this, there are several other references in demo-explorer, 
+#  and tests...
+
 ethr-did-resolver:
   $require: ethr-did-resolver?t=function&p=/ethr#getResolver
   $args:

diff --git a/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts b/packages/credential-ld/src/__tests__/issue-verify-flow.test.ts
@@ -36,6 +36,12 @@ const customContext: Record<string, ContextDoc> = {
   },
 }
 
+// TODO: remove infura dependency in tests
+// 
+// not great having external dependency in test
+// these tests should be refactored to not rely on 
+// external service
+
 const infuraProjectId = '3586660d179141e3801c3895de1c2eba'
 
 describe('credential-LD full flow', () => {