Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: renderer expand jsonld incorrectly #133

Merged

Conversation

namhoang1604
Copy link
Contributor

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

The JSON-LD lib expanded the vc with the wrong data of @id of renderMethod object.
Eg:

# The **@id** value before expanding
<div style=\"width:300px; height:100px; border: 2px solid black; text-align:center\">ABC</div>

# The **@id** value after expanding
300px; height:100px; border: 2px solid black; text-align:center\">ABC</div>

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@namhoang1604 namhoang1604 requested a review from hoa-ngo-gs July 6, 2023 06:05
@namhoang1604 namhoang1604 changed the title fix: renderer expand jsonld wrong fix: renderer expand jsonld incorrectly Jul 6, 2023
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
…e2022 provider

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604 namhoang1604 force-pushed the fix-renderer-expand-jsonld-wrong branch from 9960d43 to b2199a7 Compare July 6, 2023 06:42
@namhoang1604 namhoang1604 merged commit d6fd38f into uncefact:next Jul 6, 2023
@namhoang1604 namhoang1604 deleted the fix-renderer-expand-jsonld-wrong branch July 6, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant