Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: react components package, QR code component #134

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

namhoang1604
Copy link
Contributor

@namhoang1604 namhoang1604 commented Jul 15, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

Implement the react component that includes the QR code component and the document wrapper includes the QR code component. Both components are used to render the verifiable credential/verifiable presentation have the renderer method to attach the QRcode on the rendered document.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

@namhoang1604 namhoang1604 requested a review from hoa-ngo-gs July 15, 2023 06:55
@namhoang1604 namhoang1604 force-pushed the feat-qrcode-component branch 2 times, most recently from 2b8210a to 1a9c358 Compare July 19, 2023 08:11
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
(cherry picked from commit d234bca95aee320e1142beabe50a908a9c99b835)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant