Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: minor issues #153

Merged

Conversation

namhoang1604
Copy link
Contributor

@namhoang1604 namhoang1604 commented Aug 21, 2023

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

  • Fix migration script to ignore when the table is existing
  • Rename active button to unrevoke
  • Comment the did ethr in default config

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ vc-kit doc site
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
Signed-off-by: Nam Hoang <hoangxuannam160493@gmail.com>
@namhoang1604 namhoang1604 changed the title fix: migration script when create table fix: minor issues Aug 22, 2023
@namhoang1604 namhoang1604 merged commit cf8c801 into uncefact:next Sep 7, 2023
@namhoang1604 namhoang1604 deleted the fix/migration-table-creation branch September 7, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant